Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: introduce newDefaultReorgDistSQLCtx to replace mock context in DDL reorg #53467

Merged
merged 1 commit into from
May 28, 2024
Merged

ddl: introduce newDefaultReorgDistSQLCtx to replace mock context in DDL reorg #53467

merged 1 commit into from
May 28, 2024

Conversation

lcwangchao
Copy link
Collaborator

What problem does this PR solve?

Issue Number: ref #53388

Problem Summary:

see issue

What changed and how does it work?

  • Add method newDefaultReorgDistSQLCtx to replace mock.Context in reorg scene.
  • Add a unit test to make sure this change is equivalent to the previous logic.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 22, 2024
@tiprow tiprow
Copy link

tiprow bot commented May 22, 2024

Hi @lcwangchao. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@codecov Codecov
Copy link

codecov bot commented May 22, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.7119%. Comparing base (0afe54d) to head (434642d).
Report is 40 commits behind head on master.

Additional details and impacted files 
@@               Coverage Diff                @@
##             master     #53467        +/-   ##
================================================
+ Coverage   72.5326%   75.7119%   +3.1793%     
================================================
  Files          1505       1507         +2     
  Lines        429866     440047     +10181     
================================================
+ Hits         311793     333168     +21375     
+ Misses        98774      87084     -11690     
- Partials      19299      19795       +496
Flag Coverage Δ
integration 50.9683% <100.0000%> (?)
unit 72.5982% <100.0000%> (+1.1782%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.5014% <ø> (+9.1279%) ⬆️

@lcwangchao lcwangchao mentioned this pull request May 22, 2024
Closed
@lcwangchao
Copy link
Collaborator Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented May 22, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label May 22, 2024
YangKeao
YangKeao approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@YangKeao YangKeao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels May 24, 2024
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 24, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-22 09:17:11.621932697 +0000 UTC m=+2249585.379068263: ☑️ agreed by xhebox.
  • 2024-05-24 06:48:41.403310891 +0000 UTC m=+2413475.160446464: ☑️ agreed by YangKeao.

@lcwangchao lcwangchao mentioned this pull request May 28, 2024
Merged
13 tasks
@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tangenta, xhebox, YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 28, 2024
@lcwangchao
Copy link
Collaborator Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented May 28, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot
Copy link

ti-chi-bot bot commented May 28, 2024

@lcwangchao: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/unit-test 434642d link unknown /test unit-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@lcwangchao
Copy link
Collaborator Author

/retest

@tiprow tiprow
Copy link

tiprow bot commented May 28, 2024

@lcwangchao: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot merged commit 4bf624b into pingcap:master May 28, 2024
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tangenta tangenta tangenta approved these changes

@xhebox xhebox xhebox approved these changes

@YangKeao YangKeao YangKeao approved these changes

Assignees
No one assigned
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lcwangchao @YangKeao @xhebox @tangenta